Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buildpack to use pgbouncer 1.23.1 #195

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Update buildpack to use pgbouncer 1.23.1 #195

merged 4 commits into from
Aug 13, 2024

Conversation

xiaolin-ninja
Copy link
Contributor

https://www.pgbouncer.org/2024/08/pgbouncer-1-23-1
https://www.pgbouncer.org/2024/07/pgbouncer-1-23-0

Notable changes since last update (1.17):

  • User Name Maps for Authentication Configuration (1.23.0)
  • Allows specifying user name maps in the authentication configuration.
  • Rolling Restarts (1.23.0) [ minor breaking change. Now use SIGQUIT instead of SIGTERM ]
  • Improved support for handling replication connections through PgBouncer. (1.23.0)
  • Introduced track_extra_parameters, allowing the tracking of more parameters in transaction pooling mode. (1.22.0)
  • SQLSTATE codes are now forwarded during the authentication phase, enhancing error handling. (1.22.0)
  • Allows the use of the PGOPTIONS environment variable to set PostgreSQL parameters at startup. (1.22.0)
  • Added IntervalStyle to the tracked parameters by default. (1.22.0)

@troycoll troycoll requested review from a team, coreypurcell and brahyt-sf August 12, 2024 15:55
@troycoll
Copy link

troycoll commented Aug 12, 2024

Dev environment testing:
Follow these instructions to add pgbouncer buildpack to an app
Provision a Postgres standard-0
heroku logs -t -a app-name to tail the app's logs:

2024-08-12 16:37:51.924 UTC [21] LOG C-0x55b25cfef7f0: db2/[email protected]:54292 login attempt: db=db2 user=u3892olehdosl0 tls=no replication=no
2024-08-12T16:37:51.943547+00:00 app[pg_driver.1]: 2024-08-12 16:37:51.943 UTC [21] LOG S-0x55b25cff8190: db2/[email protected]:5432 new connection to server (from 172.18.33.46:51658)
2024-08-12T16:37:51.952458+00:00 app[pg_driver.1]: 2024-08-12 16:37:51.952 UTC [21] LOG S-0x55b25cff8190: db2/[email protected]:5432 SSL established: TLSv1.3/TLS_AES_256_GCM_SHA384/ECDH=prime256v1

Copy link

@coreypurcell coreypurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine, but do we need to do anything to support the PGOPTIONS changes?

@troycoll
Copy link

@coreypurcell I'm not sure if we want to do that, given that PGOPTIONS supports a dynamic list of parameters via the track_extra_parameters field in PgBouncer config. We can always make additions to PgBouncer config env vars or PgSettings if there are specific requests.

@troycoll troycoll merged commit a68bddc into main Aug 13, 2024
6 checks passed
@troycoll troycoll deleted the xx/1.23.1 branch August 13, 2024 12:36
@troycoll
Copy link

@edmorley this is ready to release at your convenience!

edmorley added a commit that referenced this pull request Aug 13, 2024
@edmorley
Copy link
Member

Please can I have a review for #196.

edmorley added a commit that referenced this pull request Aug 13, 2024
@edmorley
Copy link
Member

Released :-)
#196 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants