-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure tests to reduce duplication and improve runtimes #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
approved these changes
Jan 24, 2024
dzuelke
force-pushed
the
boot-scripts-test-option
branch
from
January 24, 2024 14:34
b9a5466
to
c419588
Compare
the name of the file has never made any sense drop the absolute paths test, since it'd be caught by many others (CI etc)
No updates to that project since 2017; more official deprecation can be done next
undercores for name parts, hyphens for variants
ci_spec.rb is the slowest file by far, so this will help with overall test run times
we set a low manual limit for termination, and check via the new boot script config dumper that the defaults are 3s and 30s for log and term
for better balancing in parallel_tests
for better parallelization
it executes a few more tests, for PHP 7.4 and Composer 1
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr: fewer test lines, and tests now take about 5:30-6:30 minutes instead of 7:00-8:00 minutes.
Remove duplication mostly for SIGTERM related tests, and split some tests up into smaller/faster test files to improve
parallel_tests
' ability to balance test files around based on their logged runtimes.Test file names are now more consistent (
php_concurrency_shared.rb
as the base,php-8.3_concurrency-nginx_spec.rb
as an "instance" for PHP 8.3 and Nginx).Sped up some tests, in particular the one for
request_terminate_timeout
, which is now ~25 seconds faster than before.Runs will now automatically use
ceil($numTestsForStack/2)
(based on the runtime log) parallel processes to ensure that there are enough workers for the few really slow tests to run standalone, while at the same time not having faster tests pile up for longer than the slowest test.This is better than a hard-coded process count, since it means
GUS-W-14875944