-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify autotune.php WEB_CONCURRENCY output a bit more #688
Conversation
Do not output CPU core info unless in verbose mode, but do print a notice when the number of processes gets limited to below RAM_AVAIL/memory_limit. This reduces the potential for confusion (think number of cores on shared dynos), and keeps the printed info consistent with prior versions of the buildpack.
Output examples (all with 1X dyno:
Container with 512M Bytes RAM and 8 CPU cores:
Performance-M dyno with
Container with 4G Bytes RAM and 2 CPU cores:
|
Now prints number of CPU cores and, if applied, a core-based worker limit, if there is no $DYNO env var.
6280460
to
332001f
Compare
For memory limits that do not result in an integer quotient when divided by CALC_BASE
Print calculation result in simple verbose mode, and add RAM/memory_limit result when printing limit notice
332001f
to
64e319f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is failing
7cb5f04
to
9722a58
Compare
9722a58
to
46acb26
Compare
46acb26
to
be461a4
Compare
Suddenly I am getting this:
It is on a private-s dyno type with 1024MB of memory. My public/.user.ini looks like this:
I used to get 32 workers. I don't have a $WEB_CONCURRENCY environment variable set anywhere in my settings or application. |
@jwage Hi! Trying a new app now (which doesn't have
Is it possible you are using another buildpack alongside the PHP buildpack, which is running after the PHP buildpack, and so setting it's own If so, then you need to make sure the PHP buildpack runs as the last buildpack (presuming it's the primary language for your app), as mentioned on:
|
That is it. I need the PHP buildpack to be first for another reason. I suppose I will set the env variable manually to work around this. I reordered node to be after PHP because the composer install for PHP makes something available that is necessary for the node build to succeed. |
For consistency with previous versions of the buildpack, and to reduce potential for confusion (think e.g. number of cores on shared dynos), the CPU core count is now only printed in verbose mode or when there is no
${DYNO}
env var.However, should the log_2 CPU core count based
WEB_CONCURRENCY
limit kick in, a notice is now always printed.Also adds
-h/--help
switches, and different verbosity levels.Related to #685 and #684.
Fixes #689.
GUS-W-14634717