feat: support ReadWriteOncePod #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to KEP-2485 [1], if the csi-driver exposes the SINGLE_NODE_MULTI_WRITER capability, then ReadWriteOncePod will map to the SINGLE_NODE_SINGLE_WRITER volume capability, otherwise it will map to SINGLE_NODE_WRITER. As a result, we partially supported ReadWriteOncePod but blocked it during a validation step in the `ControllerPublishVolume` method. Additional reference: - https://kubernetes.io/blog/2021/09/13/read-write-once-pod-access-mode-alpha/#accept-new-csi-access-modes [1] https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/2485-read-write-once-pod-pv-access-mode/README.md#csi-specification-changes-volume-capabilities
apricote
approved these changes
Jan 20, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #857 +/- ##
==========================================
- Coverage 32.38% 32.35% -0.04%
==========================================
Files 21 21
Lines 2075 2077 +2
==========================================
Hits 672 672
- Misses 1369 1371 +2
Partials 34 34 ☔ View full report in Codecov by Sentry. |
lukasmetzner
pushed a commit
that referenced
this pull request
Jan 22, 2025
<!-- section-start changelog --> We are pleased to announce improvements to our Nomad support. While official support is not available, we have developed end-to-end tests that cover the core features of a CSI driver. These tests are integrated into our CI pipeline and validate compatibility with the latest Nomad version. ### Features - **nomad**: improved nomad support (#798) - support ReadWriteOncePod (#857) - add support and tests for Kubernetes 1.32 (#844) ### Bug Fixes - use extraVolumeMounts for node in daemonset (#843) <!-- section-end changelog --> --- <details> <summary><h4>PR by <a href="https://github.com/apricote/releaser-pleaser">releaser-pleaser</a> 🤖</h4></summary> If you want to modify the proposed release, add you overrides here. You can learn more about the options in the docs. ## Release Notes ### Prefix / Start This will be added to the start of the release notes. ```rp-prefix We are pleased to announce improvements to our Nomad support. While official support is not available, we have developed end-to-end tests that cover the core features of a CSI driver. These tests are integrated into our CI pipeline and validate compatibility with the latest Nomad version. ``` ### Suffix / End This will be added to the end of the release notes. ```rp-suffix ``` </details> Co-authored-by: releaser-pleaser <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to KEP-2485, if the csi-driver exposes the
SINGLE_NODE_MULTI_WRITERcapability, thenReadWriteOncePodwill map to theSINGLE_NODE_SINGLE_WRITERvolume capability, otherwise it will map toSINGLE_NODE_WRITER. Our controller already responded with theSINGLE_NODE_MULTI_WRITER, but we blockedSINGLE_NODE_SINGLE_WRITERin a validation step in theControllerPublishVolumemethod.Additional reference: