refactor(installer): simplify getBaseInstallationPath function

hexadog · Oct 24, 2020 · 8257ca4 · 8257ca4
1 parent 859ff20
commit 8257ca4
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/src/ThemeInstaller.php b/src/ThemeInstaller.php
@@ -30,17 +30,15 @@ public function getInstallPath(PackageInterface $package)
 	 */
 	protected function getBaseInstallationPath()
 	{
-		if (!$this->composer || !$this->composer->getPackage()) {
-			return 'themes';
-		}
-
-		$extra = $this->composer->getPackage()->getExtra();
+		if ($this->composer && $this->composer->getPackage()) {
+			$extra = $this->composer->getPackage()->getExtra();
 
-		if (!$extra || empty($extra['theme-dir'])) {
-			return 'themes';
+			if (array_key_exists('theme-dir', $extra)) {
+				return $extra['theme-dir'];
+			}
 		}
 
-		return $extra['theme-dir'];
+		return 'themes';
 	}
 
 	/**