Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins: Add Plugin hexo-cdn-jsdelivr #1468

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

renzibei
Copy link

@renzibei renzibei commented Jul 12, 2020

Check List

Please read and check followings before submitting a PR.

  • I want to publish my theme on Hexo official website.
    • I have read the theme publishing doc.
    • name is unique.
    • link URL is correct.
    • preview URL is correct.
    • preview URL web site is rendered correctly.
    • Add a screenshot to source/themes/screenshots.
    • Screenshot filename is same as value of name.
    • Screenshot size is 800 * 500.
    • Screenshot file format is png.
  • I want to publish my plugin on Hexo official website.
  • Others (Update, fix, translation, etc...)
    • Languages:
    • en English
    • ko Korean
    • pt-br Brazilian Portuguese
    • ru Russian
    • th Thai
    • zh-cn simplified Chinese
    • zh-tw traditional Chinese

@renzibei renzibei marked this pull request as draft July 16, 2020 03:59
@renzibei renzibei marked this pull request as ready for review July 16, 2020 03:59
@renzibei
Copy link
Author

Hello, does anyone have time to review this pull request?

@SukkaW
Copy link
Member

SukkaW commented Jul 16, 2020

@renzibei I am not sure whether the plugin violates the ToS of jsDelivr or not.

@MartinKolarik Would you mind having a look at this?

@renzibei
Copy link
Author

@renzibei I am not sure whether the plugin violates the ToS of jsDelivr or not.

@MartinKolarik Would you mind having a look at this?

@SukkaW You may want to look at this issue, More explicit terms of use are needed. Though there are no explicit terms of use for jsDelivr yet, one of its developers does not seem to oppose using jsDelivr as a CDN for small sites.

@MartinKolarik
Copy link

Please wait with this for a few days until we discuss it and provide better guidelines.

@renzibei
Copy link
Author

The use policy of jsdelivr has been created #18247.
I think this plugin itself is just a tool for the convenience of website developers. It's up to the user whether it will violate the user policy of jsdelivr.
@MartinKolarik

@stevenjoezhang
Copy link
Member

Any updates on this thread?

@uiolee uiolee added Themes _data/themes/ Plugins _data/pluguns/ and removed Themes _data/themes/ labels Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Plugins _data/pluguns/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants