Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Remove main_window in favor of users creating their own windo… #1316

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

foxnne
Copy link
Contributor

@foxnne foxnne commented Dec 2, 2024

…ws. Added event window_open which is called when the platform has finished initializing the window

  • By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

…ws. Added event `window_open` which is called when the platform has finished initializing the window
@foxnne
Copy link
Contributor Author

foxnne commented Dec 2, 2024

Note that this changes how the user will interact with their window. The user is free to create a new window in App.init using core.windows.new, where they will have access to all window fields. However, the window will not be finished initializing until Platform.tick runs later on. So instead of immediately doing all pipeline setup in App.init, the user will need to defer that logic until the window_open event is run.

@emidoots emidoots merged commit ad5700c into hexops:main Dec 2, 2024
2 of 3 checks passed
@foxnne foxnne deleted the window_open branch December 2, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants