Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: small quality of life updates #1615

Merged
merged 1 commit into from
Jan 23, 2025
Merged

chore: small quality of life updates #1615

merged 1 commit into from
Jan 23, 2025

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Jan 23, 2025

No description provided.

Copy link

stackblitz bot commented Jan 23, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Jan 23, 2025

⚠️ No Changeset found

Latest commit: 8040010

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 0:59am

@mrlubos mrlubos marked this pull request as ready for review January 23, 2025 00:59
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 57.27273% with 47 lines in your changes missing coverage. Please review.

Project coverage is 56.26%. Comparing base (5cd4bb2) to head (8040010).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/openapi-ts/src/compiler/types.ts 47.22% 38 Missing ⚠️
packages/openapi-ts/src/plugins/fastify/plugin.ts 10.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1615      +/-   ##
==========================================
- Coverage   56.31%   56.26%   -0.05%     
==========================================
  Files         158      158              
  Lines       24818    24875      +57     
  Branches     1815     1816       +1     
==========================================
+ Hits        13977    13997      +20     
- Misses      10831    10868      +37     
  Partials       10       10              
Flag Coverage Δ
unittests 56.26% <57.27%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

pkg-pr-new bot commented Jan 23, 2025

Open in Stackblitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@1615

commit: 8040010

@mrlubos mrlubos merged commit 3d17490 into main Jan 23, 2025
17 checks passed
@mrlubos mrlubos deleted the chore/compiler-updates branch January 23, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant