Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: watch mode tweaks #1668

Merged
merged 1 commit into from
Feb 3, 2025
Merged

fix: watch mode tweaks #1668

merged 1 commit into from
Feb 3, 2025

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Feb 3, 2025

Closes #1534
Closes #1542

Copy link

stackblitz bot commented Feb 3, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Feb 3, 2025

🦋 Changeset detected

Latest commit: 7a03341

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 1:57am

@mrlubos mrlubos marked this pull request as ready for review February 3, 2025 01:51
};
}

if (hasChanged === undefined) {

Check notice

Code scanning / CodeQL

Unneeded defensive code Note

This guard always evaluates to true.
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 74.51565% with 171 lines in your changes missing coverage. Please review.

Project coverage is 57.16%. Comparing base (d0af19e) to head (7a03341).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/openapi-ts/src/getSpec.ts 51.33% 73 Missing ⚠️
packages/openapi-ts/src/initConfigs.ts 79.38% 66 Missing and 1 partial ⚠️
packages/openapi-ts/src/createClient.ts 84.15% 16 Missing ⚠️
packages/openapi-ts/src/processOutput.ts 78.78% 14 Missing ⚠️
packages/openapi-ts/src/getLogs.ts 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1668      +/-   ##
==========================================
+ Coverage   57.13%   57.16%   +0.03%     
==========================================
  Files         184      189       +5     
  Lines       25571    25601      +30     
  Branches     1909     1909              
==========================================
+ Hits        14609    14635      +26     
- Misses      10953    10957       +4     
  Partials        9        9              
Flag Coverage Δ
unittests 57.16% <74.51%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

pkg-pr-new bot commented Feb 3, 2025

Open in Stackblitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@1668

commit: 7a03341

@mrlubos mrlubos merged commit b005a85 into main Feb 3, 2025
17 checks passed
@mrlubos mrlubos deleted the fix/watch-mode-patch branch February 3, 2025 02:03
@github-actions github-actions bot mentioned this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve watch mode Watch mode throws error when local server reloads
1 participant