Fix verify gensim and numpy installation version check #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahdi-vajdi
changed the title
|
Hi @mahdi-vajdi , thanks for the PR. |
arxyzan
reviewed
Feb 8, 2025
| if ( | ||
| not get_lib_version("numpy").startswith(REQUIRED_NUMPY_VERSION) | ||
| or not get_lib_version("gensim").startswith(REQUIRED_GENSIM_VERSION) | ||
| version.parse(numpy_version) < version.parse(REQUIRED_NUMPY_VERSION) |
There was a problem hiding this comment.
The issue is that the gensim version must actually be 4.3.2 and the numpy version must be 1.24.* not lower.
arxyzan
reviewed
Feb 8, 2025
| @@ -28,9 +30,12 @@ | |||
|
|
|||
| # Check if the right combo of gensim/numpy versions are installed | |||
| def _verify_gensim_installation(): | |||
| numpy_version = importlib.metadata.version("numpy") | |||
There was a problem hiding this comment.
You can also use the get_lib_version under the utils which was already there and uses the exact same code you have here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Changes
Related Issues
Checklist
Additional Comments
Reviewer Instructions
Author's Note