Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip undefined array key #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

luhmannAlexander
Copy link

@luhmannAlexander luhmannAlexander commented Jun 8, 2022

Hi,

This is a bugfix for issuse 26

I test it by hand and by Uni-Test

Time: 00:00.411, Memory: 12.00 MB

OK (3 tests, 14 assertions)

@strtob
Copy link

strtob commented Jun 18, 2022

works great! please push this!

@strtob
Copy link

strtob commented Jun 19, 2022

I've tested the fix by @luhmannAlexander and it works like a charm!, thank you!

@Erwane
Copy link

Erwane commented Dec 13, 2022

But it's not merged ?

@hfig
Copy link
Owner

hfig commented Dec 14, 2022

No, as it's not a fix. It plasters over an error in the parser. No one's dug into what about it is wrong.

As I said in the issue, step 1: "verify the code is parsing the file as per the standard".

It may be the is code fine, but doesn't handle the case where the .msg file has attachments that are themselves OLE compound documents. Those attachments' named properties are stored together what those for the email - see https://learn.microsoft.com/en-us/openspecs/exchange_server_protocols/ms-oxmsg/193c169b-0628-4392-aa51-83009be7d71f

But some verification is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants