Add returntypes where possible #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In case the exact returntype is not yet possible, add it in docblock with a ReturnTypeWillChange-attribute. * Changed some instances of "static public function foo()" to "public static function foo()". * Added "public" to all constants which were public implicitly
|
OK. This looks fine. Have merged and released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a replacement for #40, I have created this PR to add return types wherever it was possible.
This should add the return types as added by the interface as well.
For the ones of the interface where it was not possible (because mixed doesn't exist yet on 7.1), we add it with in a docblock with a ReturnTypeWillChange-attribute.
Additionally, I changed some instances of "static public function foo()" to "public static function foo()".
Finally I added "public" to all constants which were public implicitly.
Dev-dependency
I added pear/pear-core-minimal as a dev-dependency because otherwise I was not able to run the unit-tests, although this will probably be fixed in pear/OLE#33.