Feature python3 #105
Open
Feature python3 #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atic_history Desactivate git patch and static history
(#MOBI-4403) revamp log system
(#MOBI-4403) fix import
…json_export (#MOBI-5212) improve newjsonencoder + fix Empty element closing
Mobi migrate to glass backend
psutils used in ikaaro, not itools
This fixes an error in ikaaro's test/test_metadata.py
As far as itools.datatypes is concerned, we don't have to deal with bytes anymore, because in Python 3 we're getting unicode strings (itools.datatypes is only used for text files). We still have the String and Unicode datatypes, where the behaviour of Unicode has not changed. The difference between them is: - String.default is None, Unicode.default is the empty string - The catalog will index a String field as is, but will split a Unicode field in words. What has changed spicifically is that now String decodes/encodes from/to str instead of bytes.
|
Thank's a lot for the works ! I will take time to read/merge/improve the PR. |
staverne
reviewed
Apr 13, 2022
| for name, info in self._metadata.iteritems(): | ||
| try: | ||
| self._metadata = loads(metadata) | ||
| except ValueError: |
There was a problem hiding this comment.
I will see if we can do better.
itools/database/registry.py
Outdated
| raise ValueError(msg.format(name, key)) | ||
| pass | ||
| #### Python 3 pass error | ||
| #raise ValueError(msg.format(name, key)) |
There was a problem hiding this comment.
I will see for better solution
| os_remove(path) | ||
| except OSError as error: | ||
| print(error) | ||
| print("File path can not be removed") |
| def to_str(self, encoding='utf-8'): | ||
| return self.data.encode(encoding) | ||
| # XXX self.data should always be unicode |
| from itools.core import get_abspath | ||
| from itools.pkg import setup as itools_setup | ||
| from itools.pkg.utils import setup as itools_setup |
| else: | ||
| sources = ['itools/office/doctotext.cc'] | ||
| extension = Extension('itools.office.doctotext', sources, **flags) | ||
| ext_modules.append(extension) | ||
|
|
||
| # if sys.version_info[0] == 3: |
| cls.internal_server_error(context) | ||
|
|
||
| # Cookies for authentification |
|
|
||
| class JWTExpiredException(TokenAuthorizationException): | ||
|
|
||
| message = MSG("Jeton expiré") |
| @@ -125,6 +125,7 @@ def git_describe(self): | |||
| return None | |||
|
|
|||
| # Parse | |||
| print(data) | |||
| @@ -40,13 +40,17 @@ def get_start_tag(value): | |||
| qname = get_attribute_qname(attr_uri, attr_name) | |||
| value = XMLAttribute.encode(value) | |||
| s += ' %s="%s"' % (qname, value) | |||
| # Close the start tag | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code review