Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HH-200040 fix getting preprocessor name #665

Closed
wants to merge 1 commit into from
Closed

HH-200040 fix getting preprocessor name #665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions frontik/preprocessors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,6 @@ def get_preprocessors(func: Callable) -> list:


def make_full_name(func: Callable | Any) -> str:
if isinstance(func, Preprocessor):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а препроцессоры только в ххапи? может тогда там это переопределить?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

только в апи, обновил там
https://github.com/hhru/hhapi/pull/2977 посмотри плз

Copy link
Contributor Author

@712u3 712u3 Nov 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

есть еще вариант из апи вообще препроцессоры выпилить, но я вот не знаю хороший ли вариант, т.к.

  1. они там хорошо смотрятся тк только какие-то чеки делают, типа "is_employer" и не возвращают данных
  2. есть еще местные просто декораторы, не препроцессоры, их тоже в зависимости превращать?

return f'{func.preprocessor_function.__module__}.{func.preprocessor_function.__name__}'
return f'{func.__module__}.{func.__name__}'