Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HH-218173 calm sentry #710

Merged
merged 1 commit into from
Jun 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions frontik/integrations/sentry.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
from __future__ import annotations

import logging
from typing import TYPE_CHECKING, Optional

import sentry_sdk
Expand Down Expand Up @@ -28,26 +27,33 @@ def initialize_app(self, app: FrontikApplication) -> Optional[Future]:
integrations_logger.info('sentry integration is disabled: sentry_dsn option is not configured')
return None

integrations = [
AioHttpIntegration(),
FastApiIntegration(),
StarletteIntegration(),
AtexitIntegration(),
DedupeIntegration(),
ModulesIntegration(),
StdlibIntegration(),
]

if options.sentry_exception_integration:
integrations.append(ExcepthookIntegration())

if options.sentry_logging_integration:
integrations.append(LoggingIntegration())

sentry_sdk.init(
dsn=options.sentry_dsn,
max_breadcrumbs=options.sentry_max_breadcrumbs,
default_integrations=False,
auto_enabling_integrations=False,
integrations=[
AioHttpIntegration(),
FastApiIntegration(),
StarletteIntegration(),
AtexitIntegration(),
DedupeIntegration(),
ExcepthookIntegration(),
ModulesIntegration(),
StdlibIntegration(),
LoggingIntegration(level=None, event_level=logging.WARNING),
],
integrations=integrations,
sample_rate=options.sentry_sample_rate,
enable_tracing=options.sentry_enable_tracing,
traces_sample_rate=options.sentry_traces_sample_rate,
in_app_include=list(filter(None, options.sentry_in_app_include.split(','))),
profiles_sample_rate=options.sentry_profiles_sample_rate,
)

return None
Expand Down
3 changes: 3 additions & 0 deletions frontik/options.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ class Options:
sentry_enable_tracing: Optional[bool] = None
sentry_traces_sample_rate: Optional[float] = None
sentry_in_app_include: str = ''
sentry_exception_integration: bool = False
sentry_logging_integration: bool = False
sentry_profiles_sample_rate: Optional[float] = None

send_timeout_stats_interval_ms: int = 60000

Expand Down
Loading