Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HH-224664 fix statsd app_name #722

Merged
merged 1 commit into from
Jul 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontik/integrations/statsd.py
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,6 @@ def create_statsd_client(options: Options, app: FrontikApplication) -> Union[Sta
options.statsd_port,
options.statsd_default_periodic_send_interval_sec,
options.statsd_max_udp_size,
app=app.app_module_name,
app=app.app_name,
)
return statsd_client
6 changes: 3 additions & 3 deletions tests/test_statsd_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@ def test_send_to_statsd(self):

metrics = '\n'.join(metrics).split('\n')

assert 'count_metric.tag1_is_tag1.tag2_is_tag2.app_is_tests-projects-test_app:10|c' in metrics
assert 'gauge_metric.tag_is_tag3.app_is_tests-projects-test_app:100|g' in metrics
assert 'time_metric.tag_is_tag4.app_is_tests-projects-test_app:1000|ms' in metrics
assert 'count_metric.tag1_is_tag1.tag2_is_tag2.app_is_test_app:10|c' in metrics
assert 'gauge_metric.tag_is_tag3.app_is_test_app:100|g' in metrics
assert 'time_metric.tag_is_tag4.app_is_test_app:1000|ms' in metrics
Loading