HH-142715 add Hibernate statistic metrics sender #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heruv1m
reviewed
Jan 10, 2022
|
|
||
| var sender = new TaggedSender(statsDSender, Set.of(new Tag(Tag.APP_TAG_NAME, serviceName))); | ||
|
|
||
| statsDSender.sendPeriodically(() -> { |
There was a problem hiding this comment.
а можно настроить период?
какой по умолчанию?
There was a problem hiding this comment.
Можно, есть перегруженный метод
https://github.com/hhru/nuts-and-bolts/blob/master/nab-metrics/src/main/java/ru/hh/nab/metrics/StatsDSender.java#L130
Но думаю, что не стоит для единообразия. В NaB'е везде используется неперегруженный вариант.
По умолчанию минута.
nicholasgribanov
approved these changes
Jan 10, 2022
heruv1m
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.hh.ru/browse/HH-142715