Change to the pattern in the user check of the ignore config #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marko-bekhta
force-pushed
the
change-to-pattern-in-the-user-field-for-ignore-check-config
branch
from
2cbebeb to
3c5a2c9
Compare
|
Or, hear me out: allow not specifying a user? :D |
|
Or, if you need a user filter for security/safety reasons, allow specifying a GitHub org team instead of a user. Because I don't really want to have yet another place where I need to remember adding people... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm thinking we can ask the bot to ignore checks for these ORM backport PRs hibernate/hibernate-orm#9343
but since anyone on the ORM team can open them ... adding a line per GH user with the same title pattern seemed like a lot of copy-pasting 😄 hence, maybe let's have the pattern for the user as well?