Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental table support when starting CockroachDB #2153

Merged
merged 1 commit into from
Mar 26, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ private String address() {
// Calling start() will start the container (if not already started)
// It is required to call start() before obtaining the JDBC URL because it will contain a randomized port
cockroachDb.start();
enableTemporaryTables();
return disableSslMode( cockroachDb.getJdbcUrl() );
}

Expand All @@ -62,13 +61,6 @@ private static String disableSslMode(String url) {
return url + "?sslmode=disable";
}

/**
* We need temporary tables when updating entities in a hierarchy
*/
private static void enableTemporaryTables() {
runSql( "SET CLUSTER SETTING sql.defaults.experimental_temporary_tables.enabled = 'true';" );
}

private static void runSql(String command) {
Container.ExecResult execResult;
try {
Expand Down
Loading