Skip to content

Commit

Permalink
Downgrade log4j to 2.24.1
Browse files Browse the repository at this point in the history 
because of the apache/logging-log4j2#3234
  • Loading branch information
@marko-bekhta
marko-bekhta committed Nov 29, 2024
1 parent 2774ace commit 74f2c45
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion build/parents/build/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@
<!-- Test dependencies -->

<!-- >>> Common -->
<version.log4j>2.24.2</version.log4j>
<version.log4j>2.24.1</version.log4j>
<version.junit>4.13.2</version.junit>
<version.junit-jupiter>5.11.3</version.junit-jupiter>
<version.junit-platform-suite-engine>1.10.0</version.junit-platform-suite-engine>
Expand Down

2 comments on commit 74f2c45

@ppkarwasz
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marko-bekhta,

Version 2.24.1 has a critical bug that causes null loggers to be returned during GC runs (see release notes).

2.24.x was a "major" minor release and we have still some outstanding bugs reported against it. In the meantime I would recommend 2.23.1 as a safe stop.

@marko-bekhta
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @ppkarwasz
Thanks for the pointers and for the suggestion! Log4j here is used only in tests to help make some log assertions. So far, it was working fine with the 2.24.1, and we only noticed that problem referenced in the commit message when upgraded to 2.24.2
Hence, I think we could probably keep the tests running against this 2.24 series, and if we spot any other issues with the future 2.24.3 (or any other future version, for that matter 😃), we'll try reporting them back to you.

Please sign in to comment.