HSEARCH-3654 Make sure that scope tracking extensions are static in p…

…arameterized class tests

- otherwise we won't register the callbacks as the constructor interceptor is never called, leading to incorrect cleanups

integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/sharding/AbstractSettingsPerShardIT.java

@@ -58,7 +58,7 @@ public static List<? extends Arguments> params() {
 	public String strategy;
 
 	@RegisterExtension
-	public SearchSetupHelper setupHelper = SearchSetupHelper.create();
+	public static SearchSetupHelper setupHelper = SearchSetupHelper.create();
 
 	public List<String> shardIds;
 

integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/analysis/AnalysisBuiltinIT.java

@@ -52,7 +52,7 @@ public static List<? extends Arguments> params() {
 	}
 
 	@RegisterExtension
-	public SearchSetupHelper setupHelper = SearchSetupHelper.create();
+	public static SearchSetupHelper setupHelper = SearchSetupHelper.create();
 	private final SimpleMappedIndex<IndexBinding> index = SimpleMappedIndex.of( IndexBinding::new );
 
 	@ParameterizedSetup

integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/work/IndexIndexingPlanIT.java

@@ -75,7 +75,7 @@ public static List<? extends Arguments> params() {
 	private final SimpleMappedIndex<IndexBinding> index = SimpleMappedIndex.of( IndexBinding::new );
 
 	@RegisterExtension
-	public final SearchSetupHelper setupHelper = SearchSetupHelper.create();
+	public static final SearchSetupHelper setupHelper = SearchSetupHelper.create();
 	private StubSession sessionContext;
 
 	@ParameterizedSetup

integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/model/BytecodeEnhancementIT.java

@@ -54,10 +54,10 @@
 class BytecodeEnhancementIT {
 
 	@RegisterExtension
-	public BackendMock backendMock = BackendMock.create();
+	public static BackendMock backendMock = BackendMock.create();
 
 	@RegisterExtension
-	public OrmSetupHelper ormSetupHelper = OrmSetupHelper.withBackendMock( backendMock );
+	public static OrmSetupHelper ormSetupHelper = OrmSetupHelper.withBackendMock( backendMock );
 	private SessionFactory sessionFactory;
 
 	@ParameterizedSetup

util/internal/test/common/src/main/java/org/hibernate/search/util/impl/test/extension/parameterized/ParameterizedClassPostDiscoveryFilter.java

@@ -11,9 +11,14 @@
 import static org.junit.platform.commons.util.AnnotationUtils.isAnnotated;
 
 import java.lang.annotation.Annotation;
+import java.lang.reflect.Field;
 import java.lang.reflect.Method;
+import java.lang.reflect.Modifier;
+
+import org.hibernate.search.util.impl.test.extension.AbstractScopeTrackingExtension;
 
 import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.extension.RegisterExtension;
 import org.junit.jupiter.engine.descriptor.ClassTestDescriptor;
 import org.junit.jupiter.engine.descriptor.MethodBasedTestDescriptor;
 import org.junit.jupiter.engine.descriptor.NestedClassTestDescriptor;
@@ -44,6 +49,7 @@ public FilterResult apply(TestDescriptor testDescriptor) {
 									+ " contains some methods annotated with @BeforeEach. " +
 									"Use @ParameterizedSetupBeforeTest instead." );
 				}
+				checkNonStaticOrmHelper( testClass );
 			}
 		}
 		// nested class inside a parameterized test -- we are not handling this option for now, so.... failing:
@@ -86,6 +92,22 @@ else if ( parameterizedClass ) {
 		return FilterResult.included( "This filter does not care about this case." );
 	}
 
+	private boolean checkNonStaticOrmHelper(Class<?> testClass) {
+		if ( Object.class.equals( testClass ) ) {
+			return false;
+		}
+		for ( Field field : testClass.getDeclaredFields() ) {
+			if ( isAnnotated( field, RegisterExtension.class )
+					&& AbstractScopeTrackingExtension.class.isAssignableFrom( field.getType() )
+					&& !Modifier.isStatic( field.getModifiers() ) ) {
+				throw new IllegalStateException( "Scope tracking extension " + field.getName()
+						+ " must be declared as static field in a @ParameterizedClass test " + testClass.getName() + "." );
+			}
+		}
+
+		return checkNonStaticOrmHelper( testClass.getSuperclass() );
+	}
+
 	private boolean hasParameterizedSetup(Class<?> testClass) {
 		return hasMethodAnnotated( testClass, ParameterizedSetup.class );
 	}