Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HSEARCH-4984 Add test deserializing payload from older Avro versions #3766

Merged
merged 1 commit into from
Oct 2, 2023
Merged

HSEARCH-4984 Add test deserializing payload from older Avro versions #3766

merged 1 commit into from
Oct 2, 2023

Conversation

marko-bekhta
Copy link
Member

yrodiere
yrodiere approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can drop the test payloads for Avro versions < 1.10 since we've never released a version of Search that would use those versions to serialize these payloads.

Otherwise this looks good, thanks :)

.../hibernate/search/mapper/orm/outboxpolling/avro/impl/EventPayloadSerializationUtilsTest.java Show resolved Hide resolved
@marko-bekhta marko-bekhta force-pushed the dep/HSEARCH-4984-upgrade-avro-add-compatibility-test branch from 1689929 to d37319d Compare October 2, 2023 10:57
yrodiere
yrodiere requested changes Oct 2, 2023
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This broke the Windows build :D

@marko-bekhta
Copy link
Member Author

marko-bekhta commented Oct 2, 2023 •
edited
Loading

🪟🪟🪟 🥲
If that won't help, I'll reboot to windows 😃

@marko-bekhta marko-bekhta force-pushed the dep/HSEARCH-4984-upgrade-avro-add-compatibility-test branch from d37319d to 66cf957 Compare October 2, 2023 12:56
@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yrodiere yrodiere merged commit fd45db9 into hibernate:main Oct 2, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrodiere yrodiere yrodiere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marko-bekhta @yrodiere