HSEARCH-4923 + HSEARCH-4985 Tidy up documentation of listener-triggered indexing vs indexing plans #3769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marko-bekhta
approved these changes
Oct 2, 2023
documentation/src/main/asciidoc/public/reference/_indexing-basics.adoc
Outdated
Show resolved
Hide resolved
documentation/src/main/asciidoc/public/reference/_indexing-plan.adoc
Outdated
Show resolved
Hide resolved
documentation/src/main/asciidoc/public/reference/_indexing-listener-triggered.asciidoc.adoc
Show resolved
Hide resolved
documentation/src/main/asciidoc/public/reference/_mapper-orm-indexing-jakarta-batch.adoc
Outdated
Show resolved
Hide resolved
documentation/src/main/asciidoc/public/reference/_indexing-explicit.adoc
Outdated
Show resolved
Hide resolved
documentation/src/main/asciidoc/public/reference/_indexing-explicit.adoc
Outdated
Show resolved
Hide resolved
documentation/src/main/asciidoc/public/reference/_indexing-explicit.adoc
Outdated
Show resolved
Hide resolved
|
Thanks @marko-bekhta! I addressed your comments, let's wait for CI and merge. |
…ltering a whole index"
Co-Authored-By: marko-bekhta <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honestly still think it's too complex and a bit confusing, but I don't really know how to make it clearer, so I'll stop here.
I'll happily take suggestions on how to simplify all this.
I'd suggest to review by rendering the documentation then reading section "14. Indexing entities", because the diff isn't going to give you a clear picture.