Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSEARCH-4997 Compatibility with Hibernate ORM 6.4 #3800

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

yrodiere
Copy link
Member

…nate ORM 6.3.x-SNAPSHOT

IIRC the breaking change in hibernate-testing was released in 6.3.1, and
we already upgraded to that version.
@yrodiere
Copy link
Member Author

This is long overdue... I'll run some tests locally to check it works... somewhat...

@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yrodiere
Copy link
Member Author

I ran this locally:

mvn clean verify -Pdependency-update -Dversion.org.hibernate.orm=6.4.0-SNAPSHOT -pl "$(./ci/list-dependent-integration-tests.sh hibernate-search-mapper-orm)"

Results:

[INFO] Hibernate Search ITs - Migration Helper - ORM ...... FAILURE [02:12 min]
[INFO] Hibernate Search ITs - ORM - Spring ................ SUCCESS [ 44.978 s]
[INFO] Hibernate Search ITs - Spring Repackaged JAR Model . SUCCESS [  1.203 s]
[INFO] Hibernate Search ITs - Spring Repackaged JAR Application SUCCESS [  7.823 s]
[INFO] Hibernate Search ITs - Showcase - Library .......... SUCCESS [ 40.799 s]
[INFO] Hibernate Search ITs - Java - Modules - ORM/Elasticsearch SUCCESS [ 17.189 s]
[INFO] Hibernate Search ITs - Java - Modules - ORM/Lucene . SUCCESS [  4.439 s]
[INFO] Hibernate Search ITs - Java - Modules - ORM/Elasticsearch outbox polling SUCCESS [ 20.137 s]
[INFO] Hibernate Search Documentation ..................... SUCCESS [04:55 min]

There was only one test failure, and I will address it as https://hibernate.atlassian.net/browse/HSEARCH-5000

@yrodiere yrodiere changed the title HSEARCH-4997 Test Hibernate Search regularly against Hibernate ORM 6.4 HSEARCH-4997 Compatibility with Hibernate ORM 6.4 Oct 24, 2023
@yrodiere yrodiere merged commit 7465f11 into hibernate:main Oct 24, 2023
10 of 11 checks passed
@yrodiere yrodiere deleted the HSEARCH-4997 branch November 29, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants