HSEARCH-4995 Use suppressed exceptions instead of logging for nested failures in RootFailureCollector #3815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marko-bekhta
approved these changes
Nov 3, 2023
engine/src/main/java/org/hibernate/search/engine/reporting/spi/RootFailureCollector.java
Outdated
Show resolved
Hide resolved
|
I addressed your comment, thanks! |
yrodiere
force-pushed
the
HSEARCH-4995
branch
from
f4f84e0 to
484aea7
Compare
…failures in RootFailureCollector
…ng on ExpectedLog4jLog
…the log level is not TRACE
yrodiere
force-pushed
the
HSEARCH-4995
branch
from
484aea7 to
d613871
Compare
|
So, we're heading towards a 7.0.0.CR2 in the end, so... let's merge this in 7.0 after all? |
|
Kudos, SonarCloud Quality Gate passed! |
|
yes ! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HSEARCH-4995
We still log such exceptions just in case, but at TRACE level (which should usually be disabled).
Please do not merge in 7.0, this is 7.1 material.