HSEARCH-5010 Disable skipping in comparators #3828
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HSEARCH-5010
I can only reproduce the test failure from time to time... the problem is caused by this change:
marko-bekhta/lucene@d910990#diff-79c6a57519ecd1ef504629e62e13d17859a4ffedc58f4602e583ce758a15adc8R288-R295
Since our RawNumericDocValues throws exceptions, the code in the mentioned block just fails. When I've tried to "implement" the two methods throwing the exception -- instead of a failed test because of the exception, the order was incorrect. But again, the issue cannot be reproduced consistently ... 😔