Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSEARCH-5010 Disable skipping in comparators #3828

Conversation

marko-bekhta
Copy link
Member

https://hibernate.atlassian.net/browse/HSEARCH-5010

I can only reproduce the test failure from time to time... the problem is caused by this change:
marko-bekhta/lucene@d910990#diff-79c6a57519ecd1ef504629e62e13d17859a4ffedc58f4602e583ce758a15adc8R288-R295

Since our RawNumericDocValues throws exceptions, the code in the mentioned block just fails. When I've tried to "implement" the two methods throwing the exception -- instead of a failed test because of the exception, the order was incorrect. But again, the issue cannot be reproduced consistently ... 😔

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please port to the lucene9 branch as well :)

But again, the issue cannot be reproduced consistently ... 😔

This doesn't worry me too much, as skipping probably is only possible when documents are distributed a specific way across fragments, and that distribution is notably unpredictable (it depends on the order of indexing operations coming from multiple threads, I think).

Since our RawNumericDocValues throws exceptions, the code in the mentioned block just fails

I think we'll want to solve this eventually, because skipping most likely enables better performance.

I created https://hibernate.atlassian.net/browse/HSEARCH-5014, could you please add the stracktrace there in a comment?

@marko-bekhta marko-bekhta force-pushed the wip/main/dependency-update/lucene10 branch from 714507e to 3469523 Compare November 15, 2023 10:04
@marko-bekhta
Copy link
Member Author

Thanks for taking a look 😃. Rebased and pushed both (lucene9/lucene10) branches. Closing this draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants