Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Groovy script to list required test containers #3838

Conversation

marko-bekhta
Copy link
Member

to work with non-docker-io registries (e.g. db2/mssql)

Right now, these won't be prefetched. It should still work out ok in the end as they can be downloaded without docker auth. But let's fetch them the same as we are doing for other containters.

to work with non-docker registries (e.g. db2/mssql)
@hibernate-github-bot
Copy link

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HSEARCH-\d+
    ↳ Offending commits: [7d59b10]

› This message was automatically generated.

Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I guess for images that explicitly target a different registry than docker.io... pulling them anyway cannot hurt, as we know we'll use them later.
And this code is simpler, so it's better!

@yrodiere yrodiere merged commit a8bb722 into hibernate:main Nov 21, 2023
10 of 11 checks passed
@marko-bekhta marko-bekhta deleted the test/update-groovy-script-for-nondocker-repositories branch November 21, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants