HBX-1797 Several improvements: descriptions of classes are taken from comments of database tables and ... #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lue of param is set to true then annotates will be generated above class fields instead of field getters. Added param "javaDocFromDbComments" to config of hibernatetool plugin. If value of param is set to true then comments of tables and their fields will be added as class and their fields javadoc description. Meta-attributes of class and fields (class-description and field-description) has priority if set.
|
Hi @Bryantsev, I will take a look at this contribution shortly. In the meantime, would it be possible to create an issue in our JIRA (https://hibernate.atlassian.net/projects/HBX) for this? |
Bryantsev
changed the title
|
Will this be merged please? I wish to propose a further enhancement around comments which will conflict/depend on this. |
eciuca
reviewed
Jun 4, 2020
| @@ -241,7 +277,7 @@ public OracleMetaDataDialect() { | |||
| element.put("TABLE_SCHEM", tableResultSet.getString(2)); | |||
There was a problem hiding this comment.
shouldn't there be an A in TABLE_SCHEM, I also noticed it in SQLServerDialect ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements are divided into 3 commit