Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Basic Crud #33

Merged
merged 6 commits into from
Sep 5, 2024
Merged

feat: Basic Crud #33

merged 6 commits into from
Sep 5, 2024

Conversation

cbolles
Copy link
Member

@cbolles cbolles commented Sep 4, 2024

Description

  • GraphQL updates for basic CRUD on
    • Service
    • Category
    • Bundle
  • Service list validation before update

Checklist

  • This PR can be reviewed in under 30 minutes
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have assigned reviewers to this PR.

@cbolles cbolles requested a review from am5815 September 4, 2024 17:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🔴 Statements
3.39% (-0.51% 🔻)
 27/796
🔴 Branches 0% 0/25
🔴 Functions
3.1% (-0.53% 🔻)
 7/226
🔴 Lines
2.83% (-0.41% 🔻)
 18/635
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🔴
... / bundles.pipe.ts
 0% 0% 0% 0%
🔴
... / update.pipe.ts
 0% 0% 0% 0%
🔴
... / categories.pipe.ts
 0% 0% 0% 0%
🔴
... / update.pipe.ts
 0% 0% 0% 0%
🔴
... / update.pipe.ts
 0% 0% 0% 0%
🔴
... / update.dto.ts
 0% 100% 0% 0%
🔴
... / update.dto.ts
 0% 100% 0% 0%
🔴
... / update.dto.ts
 0% 100% 0% 0%

Test suite run success

4 tests passing in 2 suites.

Report generated by 🧪jest coverage report action from abf6507

@cbolles cbolles force-pushed the feature/cbolles/basic-crud branch from 0c15892 to abf6507 Compare September 4, 2024 17:49
am5815
am5815 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@am5815 am5815 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@cbolles cbolles merged commit 2da2367 into main Sep 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@am5815 am5815 am5815 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbolles @am5815