PL - W18, W24, W32, WETCS, We #265
Conversation
* Added graphics for W18, W19, W20, W24 pointers * Added graphics for W32 variants * Added remaining We pointers * Added light semaphores for signals having both green (S6-S9) and orange (S10a-S13a) belts
* Standardized legend names in PL section * Combining common pointers into groups (W6, W10, W33, WETCS) * Added W32 variants * Renamed ZTM-MW to proper PL-metro standardized prefix * Changed possible speed limits at speed pointers
* Added render for W28 signals (R1-R8) * Changed cases for light signals to better reflect their real shape * Grouping signals in legend
There was a problem hiding this comment.
Wow, incredible work, thanks a lot!
Much better than my initial attempt to make sure the wiki is implemented for all the tagged signals in Poland 👍
Unrelated comment: I see some signals around Warsaw (e.g. https://www.openstreetmap.org/node/11369657607) that to not contain railway:signal:main:substitute_signal=PL-PKP:sz or railway:signal:combined:substitute_signal=PL-PKP:sz so they are not picked up as a valid main / combined PL-PKP:s signal
|
I had to revise the tagging for signals (being reading the operators railway instructions for the n-th time, to better visualise this xd), but don't worry - I will have those signals changed (being changing from 'combined' to 'main'). But I'm surprised it works |
|
Ah nodes like https://www.openstreetmap.org/node/9933671564 also work nicely now, I had to update my local database with the recent changes to get some new tagging
|
|
Around Łódź Kaliska, Around Poznań Super nice 🎉 |
| country: PL | ||
| icon: | ||
| match: 'railway:signal:speed_limit_distant:speed' | ||
| # TODO update signs from https://wiki.openstreetmap.org/wiki/Pl:OpenRailwayMap/Tagging_in_Poland#Tarcza_zwolnić_bieg_D_6 | ||
| # TODO handle dwarf signals | ||
| cases: | ||
| - { regex: '^[1-9]0$', value: 'pl/d6-{}', example: 'pl/d6-{70}' } | ||
| - { regex: '^([1-9]|1[0-9]|2[0-4])0$', value: 'pl/d6-{}', example: 'pl/d6-{70}' } |
There was a problem hiding this comment.
For this one there are only icons for speeds 10-90. So this will fail to render icons for higher speeds.
| country: PL | ||
| icon: | ||
| match: 'railway:signal:speed_limit_distant:speed' | ||
| cases: | ||
| - { regex: '^([1-9]|1[0-9]|20)0$', value: 'pl/w8-{}', example: 'pl/w8-{60}' } | ||
| - { regex: '^([1-9]|1[0-9]|2[0-4])0$', value: 'pl/w8-{}', example: 'pl/w8-{60}' } |
There was a problem hiding this comment.
Same as D6: here are only icons for speeds up to 200. So we should add icons for 210-240 as well to make this work correctly
There was a problem hiding this comment.
True, I have high resolution ones available on commons.wikimedia (KokoiMatsuchi account)
There was a problem hiding this comment.
https://commons.wikimedia.org/wiki/Category:Diagrams_of_railway_signs_in_Poland
Oh, I thought I made W8s, well, I know what I'll be doing tomorrow
There was a problem hiding this comment.
Can you add all the available icons to the pull request? Then I can compress the SVG and the PR should be good to go.
There was a problem hiding this comment.
Added, W8 will be much smaller compared to those (original size of pointers is in mm XD)
* Reduced icons dimensions to H 16px
|
I added D6, W8 and W27a (updated font) for 10 - 240 (250 for W27a) km/h |
* For existing (irl) speed limits (50 - 150 km/h)
There was a problem hiding this comment.
I honestly feel like these new icons are a downgrade compared to the old ones, as they're harder to see.
I've added graphics and some basic code to reflect pointers in PL. Those are W18 (station_distant), W24 (wrong_road), W32 with variants, WETCS11, updated WETCS10 and grouped pointers - (W6, W6a, W6b and W7), (W33 and W34), (W10a and W10b), (We10). I also standardized legend in PL section.
https://wiki.openstreetmap.org/wiki/Pl:OpenRailwayMap/Tagging_in_Poland/Pointers
The area of interest with W18 (W19, W20) and W24 is below:
https://openrailwaymap.fly.dev/#view=16.33/52.211138/20.929013&style=signals
The area of interest with W32 types is below:
https://openrailwaymap.fly.dev/#view=17.5/53.238623/20.167717&style=signals
I added graphics for W19, W20, but I haven't coded them. I hope I didn't make a mess