Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #614: Add option to override asymmetric share #616

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pranaysharmamanulife
Copy link
Contributor

Issue-614: Add option to override asymmetric share

@pranaysharmamanulife pranaysharmamanulife changed the title Issue-614: Add option to override asymmetric share Issue #614: Add option to override asymmetric share Mar 8, 2021
@hierynomus
Copy link
Owner

Adding support for _asymmetric` shares is a bit more involved than the implementation in this PR:

If Connection.Dialect is "3.0.2" or "3.1.1" and the Capabilities field in the response includes the SMB2_SHARE_CAP_ASYMMETRIC bit, the client MUST verify whether both of the following conditions are true:

  • Connection.SessionTable contains only one entry.
  • Session.TreeConnectTable contains only one entry.
    If either of the preceding conditions is FALSE, the client MUST perform the following:
  • Disconnect the tree connection as specified in section 3.2.4.22.
  • Establish a new transport connection by providing the ServerName and TransportIdentifier used in the previous connection, as specified in section 3.2.4.2.1.
  • Send an SMB2 NEGOTIATE request on the new connection, as specified in section 3.2.4.2.2.2. The client also provides a newly generated Guid to be used as ClientGuid.
  • If the SMB2 NEGOTIATE request is successful, the client MUST create a new session on the new connection by sending an SMB2 SESSION_SETUP request, as specified in section 3.2.4.2.3. The client provides the UserCredentials used in the previous connection.
  • If the SMB2 SESSION_SETUP request is successful, the client MUST send an SMB2 TREE_CONNECT request, as specified in section 3.2.4.2.4. The client provides the ShareName used in the previous connection.
  • If the SMB2 TREE_CONNECT request is successful, the client SHOULD invoke the event as specified in [MS-SWN] section 3.2.4.1 by providing Connection.ServerName as the Netname parameter and TreeConnect.ShareName as the ShareName parameter, and by setting the IsShareNameNotificationRequired parameter to TRUE.

As such, I cannot merge it in its current state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants