Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Fix NullPointerException when message field is a null #202

Merged
merged 1 commit into from
Aug 5, 2019
Merged

Fix NullPointerException when message field is a null #202

merged 1 commit into from
Aug 5, 2019

Conversation

borkaehw
Copy link
Collaborator

@borkaehw borkaehw commented Aug 5, 2019

No description provided.

@borkaehw borkaehw requested a review from SrodriguezO August 5, 2019 17:07
@borkaehw borkaehw force-pushed the reporter-null-exception branch from 39e6f32 to c32982a Compare August 5, 2019 17:29
@jjudd
Copy link
Collaborator

jjudd commented Aug 5, 2019

Can we add a test for this?

@borkaehw borkaehw force-pushed the reporter-null-exception branch from c32982a to 0d169c6 Compare August 5, 2019 19:44
@borkaehw
Copy link
Collaborator Author

borkaehw commented Aug 5, 2019

@jjudd Yes, we can. I have heard at least 3 people running into this problem. Can we ship this fix and revisit it for the test later?

@jjudd
Copy link
Collaborator

jjudd commented Aug 5, 2019

Sounds good. Can you file a GitHub issue to add a test for it, so we can prioritize it and get it on a backlog?

@borkaehw
Copy link
Collaborator Author

borkaehw commented Aug 5, 2019

Issue created #203

@borkaehw borkaehw merged commit a0812a2 into higherkindness:master Aug 5, 2019
@borkaehw borkaehw deleted the reporter-null-exception branch August 5, 2019 22:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jjudd jjudd jjudd approved these changes

@SrodriguezO SrodriguezO Awaiting requested review from SrodriguezO

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@borkaehw @jjudd @SrodriguezO