Upgrade highlight.run #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
would probably be nice to move this plugin into the monorepo @ccschmitz , do you think that's doable? |
@Vadman97 I agree! I created https://linear.app/highlight/issue/HIG-4684/migrate-gatsby-plugin-highlight-to-monorepo to follow up on that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the highlight.run package to v8.12.3 (latest). This should resolve an issue with reporting web vitals.
Also updates the README and fixes a bug in the code passing options to the
initcall. I noticed mybackendUrloption wasn't being passed as expected to send data to my local instance of Highlight for testing and noticed we're trying to passoptions.optionswhich ends up beingundefined.Linear Ticket: SUP-22 : gatsby plugin should be updated to use the latest client