-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to jakarta JAXB3 API and update some dependencies #165
Conversation
I've by design decided to change the artifact / groupId and also package names to jaxb3 to avoid conflicts with the existing jaxb2 lib. |
I'd also like to change the unofficial jaxb3 generator to use https://github.com/highsource/maven-jaxb2-plugin "official" highsource plugin with jaxb3 support (providing a pull request on this project too soon, if I can) |
yes it could be usefull. |
…ld (cxf 4.0 - jakarta)
Made migration back to highsource jaxb-maven-plugin and updated some errors on build (cxf). |
Thanks @laurentschoelens for raising this PR – we use this plugin extensively and are switching to the Jakarta namespace and package names. Hi @highsource – is there only plan to move forward with this PR? At the moment we are building our own forked version using @laurentschoelens code. But of course, we'd like to move back to using this standard plugin – either jaxb2-basics or as this PR suggests jaxb3-basics – whichever will support the Jakarta namespaces and packages. |
Thanks for your comment @evantoli I'm not sure that @highsource still there (seen some comments that suggets so). @mattrpav : I've seen that you take this project back as maintainer, could you give us some feedback about this PR and the other one made in maven-jaxb2-plugin highsource/jaxb-tools#255 that it relies on. |
Indeed, @highsource passed away; see #134. 😢 |
That was the kind of comments I've seen 😢 |
Thanks @laurentschoelens and @Stephan202 for the update. Also thanks @mattrpav for providing an update in #134 and including the message from his wife with the link to his memorial page with many beautiful remembrances. Also, @mattrpav, if there is something we can do to help with the @laurentschoelens PR please let us know. I am partway through reviewing the PR and aside from some new files (which may simply be renamed files) it seems that all other changes are related to renaming Jaxb2 to Jaxb3 – which I also think is a good idea. |
@evantoli @laurentschoelens I'm checking in. I'm hoping to get into the jakarta support here shortly. I also need this in ActiveMQ for jakarta support over there as well. |
Sorry to add more work on this PR but I've been working on #160 to end the work (initial commit contains jaxb2-fluent-api and jaxb2-value-constructor plugin migration) |
@@ -311,7 +301,7 @@ | |||
<dependency> | |||
<groupId>commons-beanutils</groupId> | |||
<artifactId>commons-beanutils</artifactId> | |||
<version>1.9.3</version> | |||
<version>1.9.4</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Treat #161
I've also reverted the deletion of distributionManagement section in parent pom :) |
Hi @laurentschoelens thanks for your effort. Do I understand you correctly, your MR also covers the other plugins (commons-lang, value-constructor, fluent-api, ...). Let me know If I can support you and @mattrpav to get this released. |
Hi @cachescrubber you got it right, my PR covers your issue by adding all remaining jaxb commons plugins. Please let me know if you have any issues. |
@mattrpav thanks for trying to merge my PR |
@laurentschoelens can you see about the build failure? https://github.com/highsource/jaxb2-basics/actions/runs/4355967241/jobs/8079143601?pr=165 |
Yes, I've looked when notified. |
|
@mattrpav any news on this ? |
Hello everyone |
Hello @Daemorinumi / @evantoli / @Stephan202 / @cachescrubber and everyone else looking for this PR. V3 of jaxb-tools is released with first jakarta support of jaxb2-basics plugins Feel free to look at the migration guide to get it work. V4 will come shortly after, based on Jaxb v4 api / runtime. Regards |
I've been looking for the highsource jaxb2-basics project for the jaxb3 / jakarta migration but didn't find it, so here is my pull request for this feature.
Tested successfully on my own project.
Build passes with -Pall profile.
Feel free to look and merge.