Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mrmatrix: coarsen should create nan_values at each resolution? #62

Open
mccalluc opened this issue Apr 19, 2019 · 1 comment
Open

mrmatrix: coarsen should create nan_values at each resolution? #62

mccalluc opened this issue Apr 19, 2019 · 1 comment

Comments

@mccalluc
Copy link
Contributor

@pkerpedjiev : Am I understanding it correctly, that there should be a nan_values at each resolution? It is not producing that right now. Without that, it would still need to consult the large matrix at resolution 1 to calculate averages. Assign back to me if there's work to do.

ts_to_mrmatrix_test.py:

class ParseTest(unittest.TestCase):
    def test_parse(self):
        ...
        self.assertEqual(list(hdf5['resolutions']['1'].keys()), ['nan_values', 'values'])
        ...
        self.assertEqual(list(hdf5['resolutions']['2'].keys()), ['values'])
@pkerpedjiev
Copy link
Member

Yes, that's correct, there should be nan_values assigned at every resolution if you want to be able to view averages at lower resolutions. Enabling that is just a matter of doing the same thing that coarsen (

grid = f['resolutions']['1']['values']
) does except with the nan_values dataset.

I don't think I ever implemented it because I didn't need to get average values.

@mccalluc mccalluc assigned mccalluc and unassigned pkerpedjiev May 28, 2019
@mccalluc mccalluc removed their assignment Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants