-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mrmatrix more flexible #71
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkerpedjiev
reviewed
Apr 24, 2019
pkerpedjiev
reviewed
May 17, 2019
pkerpedjiev
approved these changes
May 17, 2019
@pkerpedjiev : Let me resolve the conflicts and get back to you about the other questions... |
The 3d1aca9 pr build failed because it couldn't download... Hopefully just a transient network issue on Travis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #63, Fix #64
Description
What was changed in this pull request?
Tests I wrote earlier still pass, but I need to add tests of newer functionality.
Why is it necessary?
The data I'll want to load is taller than it is wide, and has no row or column labels. This tests that case.
Checklist