Fix a bug where the source node gets reclaimed by the GC #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's say the user of the library initializes it like this:
At least in the newest version of Chrome, if
source
goes out of scope and gets reclaimed by the GC, the script processor will start receiving zeroes and record silence as a result.If the user creates a source node just to pass it on to the recorder, it would be a leaky abstraction to require the user to keep a reference to it themselves. This pull request makes the library store a reference to the source node so the user wouldn't have to.
This will most likely fix #18, fix #28, and fix #29.