Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Makefile: #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Clean up Makefile: #4

wants to merge 2 commits into from

Conversation

moon-chilled
Copy link

General cleanup to make it simpler and more functional.

- Remove manual version munging and include path computation; just use pkg-config.  It's more portable and easier to read
- Don't force  to be cc; this way the user can override it with make CC=tcc (or whatever)
- Do compilation separately from linking.  This means that when more files are added, compilation can be sped up because they can all be compiled at once
- Add a 'clean' target, to remove all build artifacts
@hirigaray hirigaray self-assigned this Jul 4, 2019
@hirigaray
Copy link
Owner

Thanks for the pull request!

Say, do you happen to have tested this on other platforms (FreeBSD, OpenBSD, for example)? I'm not sure whether this is compatible everywhere, and I have no way to test that, currently.

Looks good to me, otherwise, though!

@fheee
Copy link

fheee commented Jul 4, 2019

this works for me with GNU make on Alpine linux edge.

@moon-chilled
Copy link
Author

I tested it with linux and it worked fine. I will test with freebsd later today.

@hirigaray hirigaray added the enhancement New feature or request label Jul 4, 2019
@hirigaray
Copy link
Owner

hirigaray commented Jul 4, 2019

Thanks for testing, everyone!

If it works on FreeBSD it'll probably work on OpenBSD too, and by then, I'll merge.

@moon-chilled
Copy link
Author

Alright, tada!

Sorry about the delay, my freebsd install got borked so I had to figure out how to make a VM. It works on freebsd now, and I think openbsd uses the same version of make.

@hirigaray
Copy link
Owner

hirigaray commented Jul 5, 2019

That's fine! thanks for taking your time to test.

One thing I do remember is backticks not working on OpenBSD. I'd like someone to test that, just to make sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants