Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ui updates #1442

Merged
merged 1 commit into from
Feb 14, 2024
Merged

feat: ui updates #1442

merged 1 commit into from
Feb 14, 2024

Conversation

BLuEScioN
Copy link
Collaborator

@BLuEScioN BLuEScioN commented Jan 30, 2024

Resolves the majority of the issues in this task #1430
And this #1328

@BLuEScioN BLuEScioN requested a review from He1DAr January 30, 2024 00:31
Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hiro-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 0:24am

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 314 lines in your changes are missing coverage. Please review.

Comparison is base (a826ac1) 20.01% compared to head (1a11e83) 21.85%.
Report is 7 commits behind head on main.

Files Patch % Lines
...rc/app/_components/BlockList/LayoutA/Paginated.tsx 0.00% 46 Missing and 1 partial ⚠️
src/common/components/TxIcon.tsx 0.00% 33 Missing ⚠️
...ponents/BlockList/LayoutA/useBlockListWebSocket.ts 0.00% 27 Missing and 1 partial ⚠️
...ponents/BlockList/LayoutA/usePaginatedBlockList.ts 24.24% 23 Missing and 2 partials ⚠️
src/common/components/StxPrice.tsx 0.00% 21 Missing ⚠️
.../app/_components/BlockList/LayoutA/useBlockList.ts 59.52% 17 Missing ⚠️
...rc/app/_components/BlockList/useSubscribeBlocks.ts 0.00% 16 Missing and 1 partial ⚠️
...c/features/txs-list/ListItem/MempoolTxListItem.tsx 0.00% 16 Missing ⚠️
src/common/components/transaction-item.tsx 0.00% 14 Missing and 1 partial ⚠️
.../features/txsFilterAndSort/TransactionMessages.tsx 0.00% 13 Missing ⚠️
... and 18 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1442      +/-   ##
==========================================
+ Coverage   20.01%   21.85%   +1.84%     
==========================================
  Files         508      410      -98     
  Lines        6830     6487     -343     
  Branches     1572     1389     -183     
==========================================
+ Hits         1367     1418      +51     
+ Misses       5285     4899     -386     
+ Partials      178      170       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@He1DAr He1DAr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @BLuEScioN 🎉! I've left some comments for enhancements. Let me know if you have questions or need to discuss any points.

@ginny-d
Copy link

ginny-d commented Feb 8, 2024

UI Feedback:

General:

  1. Group Transactions, Blocks and Tokens links under "Explore". This will serve from when we add Signers as well.
  2. Match styles: Dropdown style (linked below) and menu items should be regular-s
  1. Update text and link styles and spacing

Transaction filters and dropdowns:

  1. Buttons and dropdown styles: Button styles can be seen here and Dropdown styles can be seen here
  2. Empty state when filters applied needs update

Transactions list:

  • Contract deploy icon needs to be updated on the tx list (it's only updated on the Filter dropdown)
Screenshot 2024-02-08 at 15 10 47
  • Block # should link to block id page
  • Is it possible to remove the txid from the first row on the left?
Screenshot 2024-02-08 at 14 56 09

@ginny-d
Copy link

ginny-d commented Feb 13, 2024

UI Feedback:
General:

  1. Group Transactions, Blocks and Tokens links under "Explore". This will serve from when we add Signers as well.
  2. Match styles: Dropdown style (linked below) and menu items should be regular-s
  1. Update text and link styles and spacing

Transaction filters and dropdowns:

  1. Buttons and dropdown styles: Button styles can be seen here and Dropdown styles can be seen here
  2. Empty state when filters applied needs update

Transactions list:

  • Contract deploy icon needs to be updated on the tx list (it's only updated on the Filter dropdown)
Screenshot 2024-02-08 at 15 10 47 * Block # should link to block id page * Is it possible to remove the txid from the first row on the left? Screenshot 2024-02-08 at 14 56 09

Empty state when filters applied needs update

  • This should already be done
    These are done
  • Contract deploy icon needs to be updated on the tx list (it's only updated on the Filter dropdown)
  • Block # should link to block id page
  • Is it possible to remove the txid from the first row on the left?

For the following, can you please make a seperate issue. These were not a part of the original issues referenced in the description. It gets harder to track changes the bigger the PR gets, it makes the PR harder to review, and ultimately it slows down development time. In the future, it would be better to break all these down into as granular of tasks as possible and only combine the work when absolutely necessary. UI Feedback: General: Header menu: Group Transactions, Blocks and Tokens links under "Explore". This will serve from when we add Signers as well. Match styles: Dropdown style (linked below) and menu items should be regular-s Footer: Update text and link styles and spacing

I'm not seeing the "empty state when filters applied" updated. I see:
Screenshot 2024-02-13 at 11 09 30

and it should be:
301872456-5688c926-8381-4011-88bf-95ee7170e11c

Contract deploy icon now is showing the old function call icon:
Screenshot 2024-02-13 at 11 19 48

For the rest, got it, I'll separate into smaller tasks in the future

@BLuEScioN BLuEScioN merged commit bc05c67 into main Feb 14, 2024
15 of 17 checks passed
@BLuEScioN BLuEScioN deleted the feat-ui-updates branch February 14, 2024 17:03
@blockstack-devops
Copy link

🎉 This PR is included in version 1.146.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants