Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mempool header #1447

Merged
merged 1 commit into from
Feb 21, 2024
Merged

feat: mempool header #1447

merged 1 commit into from
Feb 21, 2024

Conversation

BLuEScioN
Copy link
Collaborator

Adds the mempool header

Resolves mempool header portion of this PR - #1430

Figma - https://www.figma.com/file/31q1g27k69z1yXb6r6vrRD/Stacks-Explorer-Working-File?node-id=6092%3A14261&mode=dev

@BLuEScioN BLuEScioN requested a review from He1DAr February 6, 2024 22:47
Copy link

vercel bot commented Feb 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hiro-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2024 5:01pm

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 134 lines in your changes are missing coverage. Please review.

Comparison is base (4f2cc22) 20.62% compared to head (f1a00bf) 21.45%.
Report is 21 commits behind head on main.

Files Patch % Lines
src/app/transactions/MempoolFeeStats.tsx 0.00% 49 Missing and 1 partial ⚠️
src/app/transactions/MempoolFeePieChart.tsx 0.00% 34 Missing and 1 partial ⚠️
src/app/transactions/TransactionTypeFilterMenu.tsx 0.00% 23 Missing and 8 partials ⚠️
src/common/queries/useMempoolTxStats.ts 0.00% 11 Missing and 2 partials ⚠️
src/common/components/FilterMenu.tsx 33.33% 1 Missing and 1 partial ⚠️
src/app/txid/[txId]/TxDetails/Fees.tsx 0.00% 1 Missing ⚠️
...rc/common/components/modals/unlocking-schedule.tsx 0.00% 1 Missing ⚠️
src/common/queries/useMempoolFee.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1447      +/-   ##
==========================================
+ Coverage   20.62%   21.45%   +0.83%     
==========================================
  Files         500      413      -87     
  Lines        6634     6610      -24     
  Branches     1531     1425     -106     
==========================================
+ Hits         1368     1418      +50     
+ Misses       5096     5009      -87     
- Partials      170      183      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BLuEScioN BLuEScioN changed the base branch from main to feat-ui-updates February 6, 2024 23:40
Copy link
Collaborator

@He1DAr He1DAr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty solid! I left a few comments to address. Also, could you please use the same PR name and commit message convention that's already being used in the repo? Keep up the good work!

@ginny-d
Copy link

ginny-d commented Feb 8, 2024

Some UI feedback:

Screenshot 2024-02-08 at 15 18 58 Screenshot 2024-02-08 at 15 19 12

@BLuEScioN BLuEScioN changed the title Feat mempool header feat: mempool header Feb 13, 2024
@BLuEScioN BLuEScioN requested a review from He1DAr February 13, 2024 06:09
@BLuEScioN BLuEScioN force-pushed the feat-ui-updates branch 5 times, most recently from a1adba3 to 1a11e83 Compare February 14, 2024 00:22
Base automatically changed from feat-ui-updates to main February 14, 2024 17:03
@BLuEScioN BLuEScioN merged commit 614aaf8 into main Feb 21, 2024
14 of 17 checks passed
@BLuEScioN BLuEScioN deleted the feat-mempool-header branch February 21, 2024 17:06
@blockstack-devops
Copy link

🎉 This PR is included in version 1.147.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants