Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: more details in event-observer http server logging #2160

Merged
merged 2 commits into from
Nov 12, 2024
Merged

fix: more details in event-observer http server logging #2160

merged 2 commits into from
Nov 12, 2024

Conversation

zone117x
Copy link
Member

@zone117x zone117x commented Nov 7, 2024

Closes #2158

  • Event http response logs now include details like the url, request body size, etc so they don't have to be matched with a previous log entry.
  • Aborted http requests are logged as an error with details about the request (this will identify issues like stacks-core using a short timeout).

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024 •
edited
Loading

Vercel deployment URL: https://stacks-blockchain-cgw9e5p9t-hirosystems.vercel.app 🚀

@codecov Codecov
Copy link

codecov bot commented Nov 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/event-stream/event-server.ts 90.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@zone117x zone117x requested a review from rafaelcr November 11, 2024 15:43
rafaelcr
rafaelcr approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@zone117x zone117x merged commit ed87f15 into develop Nov 12, 2024
27 checks passed
@zone117x zone117x deleted the fix/verbose-event-http-logs branch November 12, 2024 10:47
@blockstack-devops
Copy link

🎉 This PR is included in version 8.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelcr rafaelcr rafaelcr approved these changes

Assignees
No one assigned
Labels
released
Projects
API Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Event-observer http server logging improvements
3 participants
@zone117x @blockstack-devops @rafaelcr