Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: socket-io reconnect #2174

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Fix: socket-io reconnect #2174

merged 2 commits into from
Nov 21, 2024
+62 −2

Conversation

zone117x
Copy link
Member

Closes #2146

There's a bug in the socket-io client reconnection logic, where an invalid empty topic was being sent.

client.socket.on('connect_error', error => {
  console.error('Socket connection was denied by the server', error);
  // > Socket connection was denied by the server Error: Invalid topic: 
});

This PR fixes the bug in the client, and also updates the server code to ignore empty topics so that existing client versions will work.

@zone117x zone117x requested a review from rafaelcr November 21, 2024 14:02
@github-actions GitHub Actions
Copy link

Vercel deployment URL: https://stacks-blockchain-dkcjjes6g-hirosystems.vercel.app 🚀

@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

rafaelcr
rafaelcr approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zone117x zone117x merged commit b99c672 into beta Nov 21, 2024
28 checks passed
@zone117x zone117x deleted the fix/socket-io-reconnect branch November 21, 2024 14:54
blockstack-devops pushed a commit that referenced this pull request Nov 21, 2024
@semantic-release-bot
chore(release): 8.3.0-beta.2 [skip ci]
aa151db 
## [8.3.0-beta.2](v8.3.0-beta.1...v8.3.0-beta.2) (2024-11-21)

### Bug Fixes

* socket-io reconnection bug ([#2174](#2174)) ([b99c672](b99c672))
@blockstack-devops
Copy link

🎉 This PR is included in version 8.3.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

blockstack-devops pushed a commit that referenced this pull request Dec 10, 2024
@semantic-release-bot
chore(release): 8.3.0 [skip ci]
5ae6833 
## [8.3.0](v8.2.3...v8.3.0) (2024-12-10)

### Features

* option to modify estimated fees in /v2/fees/transaction proxy ([#2172](#2172)) ([9b7e97d](9b7e97d))

### Bug Fixes

* socket-io reconnection bug ([#2174](#2174)) ([b99c672](b99c672))
@blockstack-devops
Copy link

🎉 This PR is included in version 8.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelcr rafaelcr rafaelcr approved these changes

Assignees
No one assigned
Labels
released on @beta released
Projects
API Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zone117x @blockstack-devops @rafaelcr