Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/tbtc faucet amounts #2188

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Feat/tbtc faucet amounts #2188

merged 3 commits into from
Dec 17, 2024

Conversation

CharlieC3
Copy link
Member

@CharlieC3 CharlieC3 commented Dec 17, 2024

Closes #2187

  • Changes the default rBTC faucet amount from 0.5 -> 0.0001 rBTC
  • Adds a URL query option to the rBTC faucet to allow the user the request a large amount of rBTC (0.01)
  • Adds a URL query option to the rBTC faucet to allow the user the request a xlarge amount of rBTC (the original amount of 0.5)
  • Updates some Bitcoin-related text from testnet to regtest since we've replaced Bitcoin testnet with regtest on Stacks testnet

Copy link

github-actions bot commented Dec 17, 2024

Vercel deployment URL: https://stacks-blockchain-86gwnkb6t-hirosystems.vercel.app 🚀

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/api/routes/faucets.ts 87.50% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Member

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @CharlieC3!

@CharlieC3
Copy link
Member Author

Will fix the btc faucet test in a bit.

@obycode
Copy link
Member

obycode commented Dec 17, 2024

If we're concerned about the amount of BTC available, I'd recommend lowering this even further. If we think about in Sats, 0.01 is still a million Sats, so we could go much lower. We'd also want to make sure that our Stacks miners are keeping their spend low, so that other miners can join in with low amounts.

To help out, we could also:

  • Add a sink, an easy way for people to send their tBTC back to the faucet
  • Make sure that our stackers are sending their tBTC back to the faucet (or directly specifying a faucet address in their stacking commands)

@CharlieC3
Copy link
Member Author

Agreed on lowering the rBTC amount even more in wake of recent discussions, and I like the ideas you mentioned! Those can definitely be ironed out or configured in Q1 2025.
@obycode What default rBTC were you thinking would be suitable if not 0.01? 1k sats?

@obycode
Copy link
Member

obycode commented Dec 17, 2024

What default rBTC were you thinking would be suitable if not 0.01? 1k sats?

We may need to go a little higher than 1k because we have to account for what the node considers dust amounts, and will not accept transactions below, which is something like 500-600 sats for a simple transfer. Maybe 10k would be good?

Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@CharlieC3 CharlieC3 merged commit b30f16a into develop Dec 17, 2024
26 of 27 checks passed
@CharlieC3 CharlieC3 deleted the feat/tbtc-faucet-amounts branch December 17, 2024 20:28
@blockstack-devops
Copy link

🎉 This PR is included in version 8.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@aldur
Copy link

aldur commented Dec 18, 2024

Thank you for this!

If you let me know once 8.4.0 gets deployed to testnet API, I'll update the sBTC bridge code to request less.
I don't even need that, it will just work :)

@CharlieC3
Copy link
Member Author

@aldur This is live! default rBTC faucet requests are transferring 10k sats
https://mempool.bitcoin.regtest.hiro.so/tx/9d19c0f1ceff1c928d2776f49881869447cfd346d0ceea6d00af5fbb3edbd069

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Change tBTC faucet amounts
6 participants