-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/tbtc faucet amounts #2188
Feat/tbtc faucet amounts #2188
Conversation
Vercel deployment URL: https://stacks-blockchain-86gwnkb6t-hirosystems.vercel.app 🚀 |
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @CharlieC3!
Will fix the btc faucet test in a bit. |
If we're concerned about the amount of BTC available, I'd recommend lowering this even further. If we think about in Sats, 0.01 is still a million Sats, so we could go much lower. We'd also want to make sure that our Stacks miners are keeping their spend low, so that other miners can join in with low amounts. To help out, we could also:
|
Agreed on lowering the rBTC amount even more in wake of recent discussions, and I like the ideas you mentioned! Those can definitely be ironed out or configured in Q1 2025. |
We may need to go a little higher than 1k because we have to account for what the node considers dust amounts, and will not accept transactions below, which is something like 500-600 sats for a simple transfer. Maybe 10k would be good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
🎉 This PR is included in version 8.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thank you for this!
|
@aldur This is live! default rBTC faucet requests are transferring 10k sats |
Closes #2187
testnet
toregtest
since we've replaced Bitcoin testnet with regtest on Stacks testnet