-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle re-orgs for ft and nft metadata #721
Conversation
…cies in schema adherence
…g and serving token metadata images
…essing after event-replay import
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/blockstack/stacks-blockchain-api/5qfYRZStPGcWJdcRCKZGYKd8C2Ka |
Codecov Report
@@ Coverage Diff @@
## feat/tokens-metadata #721 +/- ##
========================================================
+ Coverage 64.84% 64.90% +0.06%
========================================================
Files 86 86
Lines 8667 8682 +15
Branches 1333 1339 +6
========================================================
+ Hits 5620 5635 +15
Misses 3042 3042
Partials 5 5
Continue to review full report at Codecov.
|
23f4faa
to
8127607
Compare
@zone117x to comment on the new approach for this PR |
This PR should be moved to icebox until we determine the future of this feature (token metadata resolving in the API) -- related to the discussion at #743 If we decide to keep the functionality, this PR needs updated to account for metadata being processed outside of the regular block ingestion code. |
@asimm241 yep sounds good 👍 |
Description
The PR handles
re-orgs
forFT
andNFT
metadata.closes #639
Type of Change
Testing information
Checklist
npm run test
passes