Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle re-orgs for ft and nft metadata #721

Closed
wants to merge 44 commits into from
Closed

Conversation

asimm241
Copy link
Contributor

Description

The PR handles re-orgs for FT and NFT metadata.

closes #639

Type of Change

  • New feature
  • Bug fix
  • API reference/documentation update
  • Other

Testing information

Checklist

  • Code is commented where needed
  • Unit test coverage for new or modified code paths
  • npm run test passes
  • Changelog is updated
  • @zone117x for review

asimm241 and others added 30 commits August 20, 2021 09:49
@vercel
Copy link

vercel bot commented Aug 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/blockstack/stacks-blockchain-api/5qfYRZStPGcWJdcRCKZGYKd8C2Ka
✅ Preview: https://stacks-blockchain-api-git-re-org-metadata-blockstack.vercel.app

@asimm241 asimm241 requested a review from zone117x August 24, 2021 14:09
@asimm241 asimm241 linked an issue Aug 24, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #721 (c1212ca) into feat/tokens-metadata (b9b5984) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##           feat/tokens-metadata     #721      +/-   ##
========================================================
+ Coverage                 64.84%   64.90%   +0.06%     
========================================================
  Files                        86       86              
  Lines                      8667     8682      +15     
  Branches                   1333     1339       +6     
========================================================
+ Hits                       5620     5635      +15     
  Misses                     3042     3042              
  Partials                      5        5              
Impacted Files Coverage Δ
src/datastore/common.ts 78.64% <ø> (ø)
...c/migrations/1621511823100_token-metadata-queue.ts 100.00% <ø> (ø)
src/migrations/1621511823381_nft-metadata.ts 100.00% <ø> (ø)
src/migrations/1621511832113_ft-metadata.ts 100.00% <ø> (ø)
src/tests-tokens/tokens-metadata-tests.ts 0.00% <ø> (ø)
src/api/routes/tokens/tokens.ts 89.18% <100.00%> (-0.56%) ⬇️
src/datastore/postgres-store.ts 84.62% <100.00%> (+0.07%) ⬆️
src/event-stream/tokens-contract-handler.ts 76.00% <100.00%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9b5984...c1212ca. Read the comment docs.

@asimm241 asimm241 requested a review from zone117x August 27, 2021 05:19
@zone117x zone117x force-pushed the feat/tokens-metadata branch from 23f4faa to 8127607 Compare September 1, 2021 22:43
Base automatically changed from feat/tokens-metadata to develop September 1, 2021 23:14
@agraebe
Copy link
Contributor

agraebe commented Sep 7, 2021

@zone117x to comment on the new approach for this PR

@zone117x
Copy link
Member

This PR should be moved to icebox until we determine the future of this feature (token metadata resolving in the API) -- related to the discussion at #743

If we decide to keep the functionality, this PR needs updated to account for metadata being processed outside of the regular block ingestion code.

@asimm241
Copy link
Contributor Author

@zone117x what about closing this PR and reopen another one when we finish the discussion at #743, I don't think we will be able to reuse any code from this one. What do you think?

@zone117x
Copy link
Member

@asimm241 yep sounds good 👍

@zone117x zone117x closed this Sep 14, 2021
@rafaelcr rafaelcr deleted the re-org-metadata branch October 20, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle re-orgs for the ft/nft metadata tables
3 participants