Reduce key skipping log level

This needn't be a warn.
hlascelles · Sep 10, 2024 · 2103ee5 · 2103ee5
1 parent 470a1d7
commit 2103ee5
Show file tree

Hide file tree

Showing 12 changed files with 15 additions and 12 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 1.6.2 (2024-09-10)
+
+- Reduce override log level to info [#160](https://github.com/hlascelles/figjam/pull/160)
+
 ## 1.6.1 (2024-04-28)
 
 - Add ruby 3.3 tests [#117](https://github.com/hlascelles/figjam/pull/117)

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    figjam (1.6.1)
+    figjam (1.6.2)
       thor (>= 0.14.0, < 2)
 
 GEM

diff --git a/gemfiles/psych_4.0.gemfile.lock b/gemfiles/psych_4.0.gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    figjam (1.6.1)
+    figjam (1.6.2)
       thor (>= 0.14.0, < 2)
 
 GEM

diff --git a/gemfiles/psych_5.0.gemfile.lock b/gemfiles/psych_5.0.gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    figjam (1.6.1)
+    figjam (1.6.2)
       thor (>= 0.14.0, < 2)
 
 GEM

diff --git a/gemfiles/rails_6.gemfile.lock b/gemfiles/rails_6.gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    figjam (1.6.1)
+    figjam (1.6.2)
       thor (>= 0.14.0, < 2)
 
 GEM

diff --git a/gemfiles/rails_6_1.gemfile.lock b/gemfiles/rails_6_1.gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    figjam (1.6.1)
+    figjam (1.6.2)
       thor (>= 0.14.0, < 2)
 
 GEM

diff --git a/gemfiles/rails_7.gemfile.lock b/gemfiles/rails_7.gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    figjam (1.6.1)
+    figjam (1.6.2)
       thor (>= 0.14.0, < 2)
 
 GEM

diff --git a/lib/figjam/application.rb b/lib/figjam/application.rb
@@ -108,7 +108,7 @@ def each(&block)
     end
 
     private def key_skipped(key)
-      warn "WARNING: Skipping key #{key.inspect}. Already set in ENV."
+      puts "INFO: Skipping key #{key.inspect}. Already set in ENV."
     end
   end
 end
diff --git a/lib/figjam/version.rb b/lib/figjam/version.rb
@@ -1,3 +1,3 @@
 module Figjam
-  VERSION = "1.6.1".freeze
+  VERSION = "1.6.2".freeze
 end
diff --git a/spec/figjam/application_spec.rb b/spec/figjam/application_spec.rb
@@ -214,7 +214,8 @@ def yaml_to_path(yaml)
     it "skips keys (and warns) that have already been set externally" do
       ::ENV["foo"] = "baz"
 
-      expect(application).to receive(:warn)
+      expect(application)
+        .to receive(:puts).with('INFO: Skipping key "foo". Already set in ENV.')
 
       expect {
         application.load

diff --git a/spec/figjam/env_spec.rb b/spec/figjam/env_spec.rb
@@ -35,7 +35,6 @@
       end
     end
 
-    # rubocop:disable RSpec/RepeatedSubjectCall
     context "with bang methods" do
       it "makes ENV values accessible as lowercase methods" do
         expect(env.hello!).to eq("world")
@@ -108,7 +107,6 @@
         expect { env.goodbye = "world" }.to raise_error(NoMethodError)
       end
     end
-    # rubocop:enable RSpec/RepeatedSubjectCall
   end
 
   describe "#respond_to?" do

diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -12,4 +12,4 @@
 
 Bundler.require(:test)
 
-Dir[File.expand_path("support/*.rb", __dir__)].sort.each { |f| require f }
+Dir[File.expand_path("support/*.rb", __dir__)].each { |f| require f }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -12,4 +12,4 @@

		Bundler.require(:test)

		Dir[File.expand_path("support/*.rb", __dir__)].sort.each { \|f\| require f }
		Dir[File.expand_path("support/*.rb", __dir__)].each { \|f\| require f }