Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace phoenix_html dependency with phoenix_html_helpers #12

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tmaszk
Copy link

@tmaszk tmaszk commented Jan 31, 2024

The latest version of phoenix_html package no longer includes <tag> and <content_tag> that phoenix_meta_tags uses. Those functions have been moved to phoenix_html_helpers. Also see changelog for recent changes.

This PR updates several things:

  • use phoenix_html_helpers instead of phoenix_html
  • use newer Config style (import Config vs use Mix.Config)
  • update the CI unit test pipeline to include newer versions of elixir and OTP

NOTE: phoenix_html_helpers is dependent on phoenix_html version 4 as seen in the mix file here.

@@ -1,5 +1,4 @@
defmodule PhoenixMetaTags.TagView do
use Phoenix.HTML

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to use PhoenixHTMLHelpers here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants