Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hreflang #426

Merged
merged 29 commits into from
Dec 14, 2023
Merged

Fix hreflang #426

merged 29 commits into from
Dec 14, 2023

Conversation

basecode
Copy link
Collaborator

@basecode basecode commented Dec 6, 2023

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Relates to #409

Workaround to create the sitemap for a subpage, which is not yet supported by helix-admin. See improvement ticket: https://github.com/adobe/helix-admin/issues/1752. Hence we create the sitemap statically. I added the script to the repo, with easy reproducable steps cd tools/sitemap && npm start.

Test URLs:

Copy link

aem-code-sync bot commented Dec 6, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

Copy link

aem-code-sync bot commented Dec 6, 2023

Page Scores Audits Google
/solutions/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Collaborator

@andreibogdan andreibogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@basecode basecode merged commit b535ae1 into main Dec 14, 2023
2 of 3 checks passed
@basecode basecode deleted the fix-hreflang branch December 14, 2023 09:56
@basecode basecode mentioned this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants