Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMP-4688: Add Audio errors from DARTS API should be mapped to the correct response format in Gateway #674

Merged
merged 6 commits into from
Feb 5, 2025

Conversation

Ben-Edwards-cgi
Copy link
Contributor

Links

Jira

Change description

Summary of Git Diff

This commit introduces significant modifications to various test files in the DARTS project, particularly focusing on the handling of exceptions in SOAP web service tests. The main change is the introduction of a new ServiceException class and the refactoring of existing tests to utilize this class for asserting error responses.

Highlights

  • New Imports: Added ServiceException from com.emc.documentum.fs.rt in multiple test files for standardized error handling.
  • Refactor of Test Assertions:
    • Tests that previously used AddAudioResponse for error assertions have been refactored to utilize ServiceException.
    • Various assertions were modified to check for identical error response XMLs instead of checking specific response codes.
  • New XML Payloads: Several new XML files were added for error responses, which include:
    • courtHouseNotFoundResponse.xml
    • dartsExceptionResponse.xml
    • dartsValidationExceptionAudioTooLargeResponse.xml
    • dartsValidationExceptionInvalidXmlDocumentResponse.xml
    • dartsValidationExceptionResponse.xml
  • Removed Payloads: The problemResponse.xml file was removed as it is no longer needed.
  • Enhancements in Error Handling: The AbstractClientProblemDecoder was updated to improve error handling by passing the cause of the error to the exceptions.
  • Endpoint Method Changes: The method signatures in DartsEndpoint and DartsGatewayClient were updated to accommodate the new exception handling mechanism.
  • Unit Test Updates: Adjustments were made in unit tests to reflect the changes in error handling, ensuring that tests verify the appropriate service exceptions are thrown.

These changes enhance the robustness of the error handling in the DARTS application, leading to better maintainability and clearer test assertions.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

@Ben-Edwards-cgi Ben-Edwards-cgi requested a review from a team as a code owner February 5, 2025 12:15
@Ben-Edwards-cgi Ben-Edwards-cgi requested review from davet1985, jackmaloney and cakeben and removed request for a team February 5, 2025 12:15
@Ben-Edwards-cgi Ben-Edwards-cgi enabled auto-merge (squash) February 5, 2025 17:13
@Ben-Edwards-cgi Ben-Edwards-cgi merged commit b0f635d into master Feb 5, 2025
7 checks passed
@Ben-Edwards-cgi Ben-Edwards-cgi deleted the DMP-4688 branch February 5, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants