Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIV-3528 - temporarily ignored W3C HTML validation tests #126

Merged
merged 2 commits into from
Nov 5, 2018

Conversation

hosainnet
Copy link
Contributor

@hosainnet hosainnet commented Nov 5, 2018

To unblock build.

W3C HTML validator rules changes, preventing <h*> elements to be inside
<legend>. See hmcts/look-and-feel#100

Description

Fixes #DIV-3528

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

To unblock build.

W3C HTML validator rules changes, preventing <h*> elements to be inside
<legend>. See hmcts/look-and-feel#100
Copy link
Contributor

@qzhou-hmcts qzhou-hmcts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add in the description the story to revert this change?

To unblock build.

W3C HTML validator rules changes, preventing <h*> elements to be inside
<legend>. See hmcts/look-and-feel#100
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview November 5, 2018 12:45 Inactive
@vianvi vianvi merged commit 5186692 into master Nov 5, 2018
@vianvi vianvi deleted the DIV-3528_disable_w3c_tests branch November 5, 2018 14:23
tchow8 added a commit that referenced this pull request Nov 7, 2018
* [PREVIEW] - correct flow for errors when retrieving case from cos (#99)

* correct flow for errors when retrieving case from cos

* fix sonar tests

* smoke test

* DIV-3433 - AKS deployment (#100)

* Petitioner status page - Respondent defending, awaiting answer (#101)

* add new state page

* balnk

* empty

* remove before

* added AosSubmittedAwaitingAnswer to session page

* remove last line

* remove last line

* use smoke for functional tests

* add state for awaiting answer (#104)

* Help Content changed (#107)

* Div 3420 deleted average times info (#112)

* Reverting yarn.lock changes

DIV-3420 Removed average response time info

updated oppts version to 2.0.10

* DIV-3420 Updated CTSC info

* DIV-3420 Removed endline

* DIV-3420 Fixed email and phone contact info

* DIV-3420 updated help heading

* DIV-3420 Removed unused content

* Added safe check

* DEV-3473 Set journey timeout to 300 ms (#110)

* Mini Petition bug fix & Defended Divorce status page added (#111)

* Added spacing filter

* Respond to divorce url is changed

* Change to mini petition content

* DIV-3349 chagnes

* Progress bar tests added

* OPPTS version change

* DIV-3311, 3403, 3349 changes

* OPPTS version not picked

* Exclude mocks in sonar scan

* Sonar test fix

* Enable lint complexity

* Adding null check on G connection

* Removed preserveSession middleware and updated yarn (#114)

* use opp branch as test (#115)

* Revert "use opp branch as test (#115)" (#119)

This reverts commit 68db7e5.

* Removal of content (#116)

* [PREVIEW] div-3376 Change fields to claimsCostsFrom (#89)

* Change fields to claimsCostsFrom

* empty

* Change do not clean cost condition

* Revert Change

* dontClaimDifferentAmount display

* Fix unit test

* add claimCosts

* fix tests

* DIV-3496 Use static use contact (#117)

* use opp branch as test (#123)

* update packages (#124)

* DIV-3528 - temporarily ignored W3C HTML validation tests (#126)

* Updated CP config (#121)

Make test fails

Revert "Updated CP config"

This reverts commit c60c0aa.

Revert "Revert "Updated CP config""

This reverts commit 606bdf5.

Revert "Make test fails"

This reverts commit 0c0b21e.

* Base changes for dn no response

* DnNoResponse page changes

* Adding Tests for no response page

* DnNoReponse changes

* DnNoResponse navigation changes in progress bar

* HTML warnings resolved

* Replacing husband/wife with divorceWho

* Constants added, content segregated

* petitioner name should be displayed

* Update DnNoResponse.content.json

* Updating content

* Add some more tests for untested fields mini-petition (#129)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants