Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSCSCI-1605 AirLookup 23 #1698

Merged
merged 13 commits into from
Feb 20, 2025
Merged

SSCSCI-1605 AirLookup 23 #1698

merged 13 commits into from
Feb 20, 2025

Conversation

KatKovacs1
Copy link
Contributor

@KatKovacs1 KatKovacs1 commented Jan 27, 2025

Jira link

See SSCSCI-1605

Change description

Updated AIRLookup file to 23.1

Updated epims ids

Venue ID Venue name epims change
1256 Chelmsford 624810 -> 816875
43 Milton Keynes Magistrates Court 815997 -> 497356

Set the following venues to not active and zeroed the epims id in the venue lookup file:

Venue ID Venue name epims
86 Campbeltown 999998
94 Galashiels 999993
97 Dumfries 999997
106 Kilmarnock 999991
109 Kirkwall 999989
110 Lerwick 999988
114 Stranraer 999984
115 Wick 999983
203 Southampton 43104
221 Berwick 999974
1003 Manchester MAT 512401
1045 Bodmin 271813
1149 Benbecula 999999
1193 Chester Magistrate's Court 443014

Updated tests for port of entry

Port of entry code Old venue name New venue name
GBSTGRK00 Dumfries Ayr
GBSTGRK06 Stranraer Ayr
GBSTKWL00 Kirkwall Inverness
GBSTLER00 Lerwick Inverness
GBSTGRK11 Dumfries Ayr
GBSTLER01 Lerwick Inverness
GBSTINV05 Wick Inverness
GBSTGRK12 Stranraer Ayr
GBSTKWL01 Kirkwall Inverness
GBSTINV07 Wick Inverness
GBATLSI00 Lerwick Inverness
GBATWIK00 Wick Inverness

Testing done

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

@KatKovacs1 KatKovacs1 force-pushed the SSCSCI-1605-AIRLookUp-23 branch 2 times, most recently from 3aa8bcf to b384dd9 Compare January 30, 2025 11:22
@KatKovacs1 KatKovacs1 force-pushed the SSCSCI-1605-AIRLookUp-23 branch 2 times, most recently from 4bbd443 to f4a2c1e Compare February 10, 2025 10:16
@KatKovacs1 KatKovacs1 force-pushed the SSCSCI-1605-AIRLookUp-23 branch from 401d7bf to e29481b Compare February 14, 2025 09:29
@KatKovacs1 KatKovacs1 marked this pull request as ready for review February 14, 2025 10:06
@KatKovacs1 KatKovacs1 requested a review from a team as a code owner February 14, 2025 10:06
@KatKovacs1 KatKovacs1 merged commit dfd8200 into master Feb 20, 2025
7 checks passed
@KatKovacs1 KatKovacs1 deleted the SSCSCI-1605-AIRLookUp-23 branch February 20, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants